feat: broken-anchor indicator for orphaned annotations by leotrs · Pull Request #352 · aris-pub/studio

leotrs · 2026-03-27T19:30:48Z

Summary

When an annotation's anchor can't be resolved (text deleted, structure changed), the card now shows a visual "Original text no longer found" warning banner with an AlertTriangle icon
Orphaned cards get a dashed left border and reduced opacity to distinguish them from anchored annotations
DockableAnnotations tracks orphaned IDs during sort and passes orphaned prop to Note component

Test plan

Verify orphaned annotations show the warning banner in the sidebar
Verify anchored annotations do NOT show the banner
Verify delete still works on orphaned annotations
Verify collapsing an orphaned card hides the banner (shows collapsed preview)
12 new unit tests covering orphan detection and UI rendering

🤖 Generated with Claude Code

netlify · 2026-03-27T19:30:54Z

✅ Deploy Preview for rsm-studio-site canceled.

Name	Link
🔨 Latest commit	`8439f5a`
🔍 Latest deploy log	https://app.netlify.com/projects/rsm-studio-site/deploys/69c9553265b8c600084e0754

netlify · 2026-03-27T19:31:02Z

✅ Deploy Preview for rsm-studio-frontend canceled.

Name	Link
🔨 Latest commit	`8439f5a`
🔍 Latest deploy log	https://app.netlify.com/projects/rsm-studio-frontend/deploys/69c955328c8bec0008e64756

leotrs · 2026-03-27T20:02:15Z

Needs human review

What changed: Orphaned annotations now show a visual "Original text no longer found" warning banner with dashed border and reduced opacity. Per-message edit/delete buttons added to annotation cards. Shared card design overhauled (removed top border, added subtle shadow). Delete blocked on shared annotation messages (new 403). updated_at column added to annotation messages with "edited" indicator.

Review checklist:

Open the deploy preview: https://deploy-preview-352--rsm-studio-frontend.netlify.app
Open a document with annotations, then delete the anchored text for one annotation — verify the orphaned card shows a dashed left border, reduced opacity, and an orange "Original text no longer found" banner
Hover over the orphaned card — verify opacity returns to full
Collapse the orphaned card — verify the banner disappears (only collapsed preview shown)
Click delete on the orphaned card — verify it still works
On a private annotation, activate the card and verify Edit and Delete buttons appear below the note text
Edit a private note — verify the inline textarea appears, Save/Cancel work, and an "edited" tag appears after saving
Delete a private note — verify the two-click confirmation pattern (first click arms, second click deletes)
On a shared annotation thread, activate the card and verify the inline edit pencil icon appears on hover for your own messages
Edit a shared thread message — verify the inline textarea and "edited" tag behavior
Verify there is no delete button on individual shared thread messages
Check that the shared card redesign looks correct: no top colored border, subtle shadow instead of border, italic quoted text with background

What to look for:

Orphan banner alignment, icon color (orange), and text readability
Dashed border style and opacity transition on orphaned cards
Edit/delete buttons only appear for your own messages
"edited" tag with middle-dot separator renders correctly in both header (private) and thread message header (shared)
Shared card shadow looks clean — no double borders or visual artifacts
Avatar size change (16px → 12px) doesn't break layout elsewhere
No regressions on non-orphaned annotation cards

…rk unwrap Backend: add updated_at column to annotation_messages, set on edit, block DELETE on shared annotations. Frontend: per-message edit/delete with inline actions (Proposal C), shared annotation card visual redesign (shadow-based, tinted quote, no colored borders), fix clearHighlights DOM corruption when unwrapping nested/overlapping marks by processing innermost-first and deferring normalize(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

When an annotation's anchor text can no longer be found in the document, the card now displays a warning banner ("Original text no longer found") with an AlertTriangle icon and dashed border styling. Orphaned IDs are tracked in DockableAnnotations and passed as a prop to Note. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The shared card redesign intentionally removed the Avatar from the header. Update the E2E test to match the new design. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…build Merge conflict from a prior commit left duplicate declarations of onCancelMessageEdit, onDeleteMessageClick, onDeleteMessage, and onPostReply. The first set contained broken implementations (e.g. onPostReply called updateNote instead of addNote with undefined vars). Kept the correct second set which has proper error handling and toasts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-29T13:50:09Z

Preview Deploy

Frontend: https://pr-352--rsm-studio-frontend.netlify.app
Backend: https://aris-backend-pr-352.fly.dev
API docs: https://aris-backend-pr-352.fly.dev/docs

This preview will be destroyed when the PR is closed.

…t focus outline The active class and editing class were not accounting for the per-message edit flow (editingMessageId), causing the active border to remain visible during editing. Also added missing .edit-input:focus outline style for a11y. Updated tests to match the per-message edit flow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

leotrs · 2026-03-29T16:47:36Z

Needs human review

What changed: Orphaned annotations (anchor text deleted/changed) now show a warning banner with "Original text no longer found", dashed left border, and reduced opacity. Also replaced TextareaInput with native <textarea> for message editing and removed toast error feedback on save/edit failures.

Review checklist:

Open the app and create an annotation on some text
Delete or modify the anchored text so the annotation becomes orphaned
Verify the orphaned card shows the orange "Original text no longer found" banner with AlertTriangle icon
Verify the orphaned card has a dashed left border and slightly reduced opacity (0.75)
Hover over the orphaned card — opacity should return to 1
Collapse the orphaned card — the banner should disappear, showing only the collapsed preview
Verify non-orphaned annotations do NOT show the banner or dashed border
Try deleting an orphaned annotation — should still work
Edit a message on any annotation — verify the native textarea works (Enter to save, Esc to cancel)
Trigger an edit save failure (e.g., disconnect network) — verify no toast appears but the edit area closes gracefully

What to look for:

Orange banner styling matches the design system (consistent with other warning states)
Dashed border is visually distinct but not distracting
Opacity transition on hover feels smooth
Native textarea edit experience is equivalent to the previous TextareaInput component (no regressions in keyboard handling)
Removal of toast error feedback is intentional — confirm no silent failures confuse users

leotrs and others added 3 commits March 29, 2026 12:08

fix: remove avatar assertion from shared card E2E test

a534350

The shared card redesign intentionally removed the Avatar from the header. Update the E2E test to match the new design. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

leotrs force-pushed the std-2roe branch from 67445dd to a534350 Compare March 29, 2026 10:08

leotrs added 2 commits March 29, 2026 12:19

fix: sync preview workflow with main

81fba5f

trigger preview deploy

121e913

leotrs closed this Mar 29, 2026

leotrs reopened this Mar 29, 2026

leotrs and others added 5 commits March 29, 2026 15:05

trigger preview deploy

0ba28d4

Merge remote-tracking branch 'origin/main' into std-2roe

2740388

sync preview workflow

949650e

sync preview workflow from main

dbfa3f7

leotrs and others added 9 commits March 29, 2026 16:11

fix: allocate IPs + alembic DATABASE_URL fallback

580aac3

fix: strip sslmode from Fly DATABASE_URL for asyncpg compatibility

0ec409d

fix: strip sslmode + allocate IPs

fd8c81b

fix: strip query params from DATABASE_URL

e70856d

fix: ssl=disable for asyncpg

b916524

feat: seed preview DB with test data

12087c7

fix: seed sh -c

ee1cb14

fix: sort imports in reset_test_user.py to pass ruff I001

8439f5a

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: broken-anchor indicator for orphaned annotations#352

feat: broken-anchor indicator for orphaned annotations#352
leotrs wants to merge 19 commits intomainfrom
std-2roe

leotrs commented Mar 27, 2026

Uh oh!

netlify bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

leotrs commented Mar 27, 2026

Uh oh!

github-actions bot commented Mar 29, 2026

Uh oh!

leotrs commented Mar 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

leotrs commented Mar 27, 2026

Summary

Test plan

Uh oh!

netlify bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rsm-studio-site canceled.

Uh oh!

netlify bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rsm-studio-frontend canceled.

Uh oh!

leotrs commented Mar 27, 2026

Needs human review

Uh oh!

github-actions bot commented Mar 29, 2026

Preview Deploy

Uh oh!

leotrs commented Mar 29, 2026

Needs human review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

netlify bot commented Mar 27, 2026 •

edited

Loading

netlify bot commented Mar 27, 2026 •

edited

Loading